[
https://issues.apache.org/jira/browse/GEODE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936916#comment-15936916
]
ASF subversion and git services commented on GEODE-2535:
--------------------------------------------------------
Commit 5ed0b4d18b33b2cc414da43ac6136b79f2351210 in geode's branch
refs/heads/develop from [~eshu]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5ed0b4d ]
GEODE-2535: added a boolean flag to track if the value of a RecoveredEntry is
in memory or on disk
Update stat based on the boolean value.
Avoid negating keyId by using the boolean flag.
> DiskId keyId is not correctly updated
> -------------------------------------
>
> Key: GEODE-2535
> URL: https://issues.apache.org/jira/browse/GEODE-2535
> Project: Geode
> Issue Type: Bug
> Components: persistence
> Reporter: Darrel Schneider
>
> On a persistent region the DiskId keyId will be set negative if the value is
> not in memory but can be read from disk.
> The code correctly sets it the first time an entry is recovered from disk but
> does not correctly update it if a that same entry is recovered more than once
> from disk. This can happen when a krf for an oplog does not exist. The same
> entry can have multiple records for the same key.
> They code that does not correctly update DiskId keyId is in these methods:
> org.apache.geode.internal.cache.DiskEntry.Helper.basicUpdate(DiskEntry,
> LocalRegion, Object, EntryEventImpl): see the section that handles
> RecoveredEntry
> and
> org.apache.geode.internal.cache.DiskEntry.Helper.updateRecoveredEntry(PlaceHolderDiskRegion,
> DiskEntry, RecoveredEntry, RegionEntryContext)
> The only issue with not updating this keyId is that it can cause the "inVM"
> and "onDisk" statistics to be incorrect.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
