Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r108006539
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -407,17 +407,21 @@ class ChunkedFunctionExecutionResponse : public
TcrChunkedResult {
// CacheableVectorPtr m_functionExecutionResults;
bool m_getResult;
ResultCollectorPtr m_rc;
- ACE_Recursive_Thread_Mutex* m_resultCollectorLock;
+ std::shared_ptr<ACE_Recursive_Thread_Mutex> m_resultCollectorLock;
// disabled
ChunkedFunctionExecutionResponse(const
ChunkedFunctionExecutionResponse&);
ChunkedFunctionExecutionResponse& operator=(
const ChunkedFunctionExecutionResponse&);
public:
+ inline ChunkedFunctionExecutionResponse(TcrMessage& msg, bool getResult,
+ ResultCollectorPtr rc)
+ : TcrChunkedResult(), m_msg(msg), m_getResult(getResult), m_rc(rc) {}
+
inline ChunkedFunctionExecutionResponse(
TcrMessage& msg, bool getResult, ResultCollectorPtr rc,
- ACE_Recursive_Thread_Mutex* resultCollectorLock = NULL)
+ std::shared_ptr<ACE_Recursive_Thread_Mutex> resultCollectorLock)
--- End diff --
Same comment about `const &`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
