Yes, the test failure is intermittent. It's up to the group if we want to release with intermittently failing tests. These are new tests, so we do seem to be creating new flaky tests. I would tend to take a more hardline approach which says if the build is RED we don't ship.
Jared and I have been digging into the cause, and it seems to be these new DUnit Locator/Server starter rules which appear to be more complicated than they need to be and are promoting pollution of later tests. They are being used in several dozen tests. We'll have to put other work on hold in order to refactor these rules sufficiently to make the tests pass consistently. On Wed, Mar 29, 2017 at 11:50 AM, Anthony Baker <aba...@pivotal.io> wrote: > Kirk, > > If I run the test locally it passes. I don’t believe the changes between > 1.1.0 and 1.1.1 RC2 would have affected this area of the code. Do you > agree? What happens when you run the test? > > Anthony > > > > On Mar 28, 2017, at 5:19 PM, Kirk Lund <kl...@apache.org> wrote: > > > > -1 > > > > We still have failing tests in Geode-release #50 (this is the most recent > > CI for Geode-release). I assume "Geode-release #50" is testing v1.1.1 > RC2. > > > > org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e> > > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > > Method) > > at > > sun.reflect.NativeConstructorAccessorImpl.newInstance( > NativeConstructorAccessorImpl.java:62) > > at > > sun.reflect.DelegatingConstructorAccessorImpl.newInstance( > DelegatingConstructorAccessorImpl.java:45) > > at > > org.apache.geode.management.internal.configuration. > ClusterConfigImportDUnitTest.before(ClusterConfigImportDUnitTest.java:63) > > > > org.apache.geode.management.internal.configuration. > ClusterConfigImportDUnitTest > >> testImportWithRunningServerWithData FAILED > > org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e> > > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > > Method) > > at > > sun.reflect.NativeConstructorAccessorImpl.newInstance( > NativeConstructorAccessorImpl.java:62) > > at > > sun.reflect.DelegatingConstructorAccessorImpl.newInstance( > DelegatingConstructorAccessorImpl.java:45) > > at > > org.apache.geode.management.internal.configuration. > ClusterConfigImportDUnitTest.before(ClusterConfigImportDUnitTest.java:63) > > > > org.apache.geode.management.internal.configuration. > ClusterConfigImportDUnitTest > >> testImportWithMultipleLocators FAILED > > org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e> > > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > > Method) > > at > > sun.reflect.NativeConstructorAccessorImpl.newInstance( > NativeConstructorAccessorImpl.java:62) > > at > > sun.reflect.DelegatingConstructorAccessorImpl.newInstance( > DelegatingConstructorAccessorImpl.java:45) > > at > > org.apache.geode.management.internal.configuration. > ClusterConfigImportDUnitTest.before(ClusterConfigImportDUnitTest.java:63) > > > > org.apache.geode.management.internal.configuration. > ClusterConfigDistributionDUnitTest > >> testConfigurePDX FAILED > > org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e> > > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > > Method) > > at > > sun.reflect.NativeConstructorAccessorImpl.newInstance( > NativeConstructorAccessorImpl.java:62) > > at > > sun.reflect.DelegatingConstructorAccessorImpl.newInstance( > DelegatingConstructorAccessorImpl.java:45) > > at > > org.apache.geode.management.internal.configuration. > ClusterConfigDistributionDUnitTest.before(ClusterConfigDistributionDUnit > Test.java:66) > > > > org.apache.geode.management.internal.configuration. > ClusterConfigDistributionDUnitTest > >> testIndexAndAsyncEventQueueCommands FAILED > > org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e> > > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > > Method) > > at > > sun.reflect.NativeConstructorAccessorImpl.newInstance( > NativeConstructorAccessorImpl.java:62) > > at > > sun.reflect.DelegatingConstructorAccessorImpl.newInstance( > DelegatingConstructorAccessorImpl.java:45) > > at > > org.apache.geode.management.internal.configuration. > ClusterConfigDistributionDUnitTest.before(ClusterConfigDistributionDUnit > Test.java:66) > > > > 6812 tests completed, 13 failed, 601 skipped > > :geode-core:distributedTest FAILED > > > > On Tue, Mar 28, 2017 at 3:20 PM, Swapnil Bawaskar <sbawas...@pivotal.io> > > wrote: > > > >> +1 > >> > >> - Built from source > >> - start a few members/created regions/inserted data from gfsh > >> - verified that GEODE-2670 is fixed. > >> > >> On Mon, Mar 27, 2017 at 10:18 PM Anthony Baker <aba...@apache.org> > wrote: > >> > >>> This is the second release candidate of the release for Apache Geode, > >>> version 1.1.1. > >>> > >>> It fixes the following issues: > >>> > >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > >> ctId=12318420&version=12340271 > >>> > >>> *** Please download, test and vote by Thursday, March 30, 2200 hrs US > >>> Pacific. *** > >>> > >>> Note that we are voting upon the source (tag): > >>> rel/v1.1.1.RC2 > >>> > >>> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=tag;h= > >> refs/tags/rel/v1.1.1.RC2 > >>> > >>> Commit ID: e2081044ea0afca1cb38d62c7f34e7363b45ad97 > >>> > >>> Source and binary files: > >>> https://dist.apache.org/repos/dist/dev/geode/1.1.1.RC2/ > >>> > >>> Maven staging repo: > >>> https://repository.apache.org/content/repositories/ > orgapachegeode-1018 > >>> > >>> Geode's KEYS file containing PGP keys we use to sign the release: > >>> https://github.com/apache/geode/blob/release/1.1.1/KEYS > >>> > >>> pub 4096R/C72CFB64 2015-10-01 > >>> Fingerprint=948E 8234 14BE 693A 7F74 ABBE 19DB CAEE C72C FB64 > >>> > >>> > >>> Thanks, > >>> Anthony > >>> > >> > >
