Github user jhuynh1 commented on a diff in the pull request:

    https://github.com/apache/geode/pull/444#discussion_r110718931
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java ---
    @@ -1261,7 +1333,14 @@ void basicUpdateEntryVersion(EntryEventImpl event) 
throws EntryNotFoundException
       }
     
       protected void distributeUpdateEntryVersionOperation(EntryEventImpl 
event) {
    -    new UpdateEntryVersionOperation(event).distribute();
    +    UpdateEntryVersionOperation op = new 
UpdateEntryVersionOperation(event);
    +    long viewVersion = -1;
    +    try {
    +      viewVersion = op.startOperation();
    --- End diff --
    
    Out of curiosity, what happens if the startOperation() method returns a -1 
(I think that may be possible based on how it's currently written or if an 
exception is thrown before token is assigned.  What is the expected way to 
handle endOperation with an invalid/-1 token?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to