----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58325/#review171495 -----------------------------------------------------------
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ServerRule.java Lines 47 (patched) <https://reviews.apache.org/r/58325/#comment244426> Is there no other way to configure this other than with hidden system properties? I was hoping there would be something in ConfigurationProperties to configure the Pulse port. I suppose that LauncherLifecycleCommands#startPulse would already be configuring things but it's rather sparse for configuration. Also, I notice that you're using "jmxPort" for the Pulse port. Shouldn't this be "pulsePort"? The "jmxPort" would theoretically be the RMI server port for JMX instead. - Kirk Lund On April 10, 2017, 9:52 p.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58325/ > ----------------------------------------------------------- > > (Updated April 10, 2017, 9:52 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kirk Lund, and Patrick > Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-2737: Change Pulse UI tests to use random port for JMX connections > > > Diffs > ----- > > > geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ServerRule.java > af3d64bd5118ff870fadc16dcdeb3cde858611ce > > > Diff: https://reviews.apache.org/r/58325/diff/1/ > > > Testing > ------- > > All Pulse UI tests run locally pass. > > Precheckin is running > > > Thanks, > > Ken Howe > >
