Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/449#discussion_r111036455
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/CreateIndexFunction.java
---
@@ -93,6 +91,31 @@ public void execute(FunctionContext context) {
}
}
+ private void setResultInSender(FunctionContext context, IndexInfo
indexInfo, String memberId,
+ Cache cache, String regionPath) {
+ if (regionPath == null) {
+ String message =
CliStrings.format(CliStrings.CREATE_INDEX__INVALID__REGIONPATH,
+ indexInfo.getRegionPath());
+ context.getResultSender().lastResult(new CliFunctionResult(memberId,
false, message));
+ } else {
+ XmlEntity xmlEntity =
+ new XmlEntity(CacheXml.REGION, "name",
cache.getRegion(regionPath).getName());
+ context.getResultSender().lastResult(new CliFunctionResult(memberId,
xmlEntity));
+ }
+ }
+
+ private String getValidRegionName(Cache cache, String regionPath) {
+ while (cache.getRegion(regionPath) == null && regionPath != null) {
--- End diff --
If regionPath is null, will cache.getRegion(regionPath) throw an exception?
Shouldn't the regionPath check for null be first?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
