----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58484/#review172284 -----------------------------------------------------------
Ship it! Ship It! - Jared Stewart On April 17, 2017, 10:27 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58484/ > ----------------------------------------------------------- > > (Updated April 17, 2017, 10:27 p.m.) > > > Review request for geode, Bruce Schuchardt, Darrel Schneider, Jinmei Liao, > Jared Stewart, Ken Howe, Udo Kohlmeyer, and Dan Smith. > > > Bugs: GEODE-2632 > https://issues.apache.org/jira/browse/GEODE-2632 > > > Repository: geode > > > Description > ------- > > Purpose: Refactoring code in steps to eventually fix security/client-server > performance > Part 1: https://reviews.apache.org/r/58460/ > > Refactor code to use internal interfaces > > * refactor code to use InternalCache instead of GemFireCacheImpl > * refactor code to use getInternalDistributedSystem > * delete dead code, unused code, unused imports, extra whitespace, > useless javadocs and comments, fix typos > > The end goals of multiple iterations of refactoring: 1) write high-level > benchmark for client put to server [done], 2) change internal dependencies > from impl class to interface (including GemFireCacheImpl to InternalCache), > 3) fix constructors and invert dependencies of internal classes (including > AcceptorImpl and client Command classes), 4) write low-level benchmark(s) for > client commands, 5) fix any performance issues involving SecurityService. > > I'd like to commit each iteration of refactoring as I go to keep the number > of merge conflicts and number of modified files lower. > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java > 0103cf6d8d6f088b4bd3ffc30f8e52b977a82621 > > geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java > b2881082278bdb53a8553a7fd31c47c304eb1ef6 > > geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java > 03f079964c5e12c1ba44ba240f12025a5b098a09 > > geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java > 08a5b003d6e3c5cdec8ad22b74153f2c31cde9f7 > > geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegion.java > e69f801d4f307c3ce98c105d6d2e38460d0d4a67 > > geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java > a3c4a931b95fb3a8ea6463bb027aadd1bc8fdd32 > > geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreFactoryImpl.java > 71be7ec00deb6dc774f84e0fcca291a310ba09e4 > geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java > b97f4286b6e2352a4ec5637477641d868cb05a6c > > geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreMonitor.java > 2bb510720f2374ae1159095bff293f88465e600c > > geode-core/src/main/java/org/apache/geode/internal/cache/DistTXStateProxyImplOnCoordinator.java > 52d155f5eebff2dd6eb50fbada159aca6629c1ec > > geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java > 68fdbebac6a50efb7092717d56243c7b88a47ec5 > geode-core/src/main/java/org/apache/geode/internal/cache/ExpiryTask.java > e12622d070b932979a6ca400d47eeff36c142f21 > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > 869181432a64c2683e1b606e621cb5dbd1b42589 > geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java > ee80014b393ba5d625cb78cf12a2a6e2c2fc24b3 > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java > 55ee6a8e1ba7351c87d6f63f530469699efa8ee2 > > geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java > 8db89699ceb2e23fd4ae8ce62b0fad76421656b0 > > geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionHelper.java > 99ab281052b11e1a1168d99f8e1047fb4f822ca2 > > geode-core/src/main/java/org/apache/geode/internal/cache/ProxyBucketRegion.java > 27f73c7514b3ff6f20041ac6c8ce72d3c1798977 > > geode-core/src/main/java/org/apache/geode/internal/cache/SearchLoadAndWriteProcessor.java > 2a10792a7a26ead58fcf941fe4190117f552a6c5 > > geode-core/src/main/java/org/apache/geode/internal/cache/ServerPingMessage.java > 0e468912614292d23cda0fd32e4126a0e0235a59 > geode-core/src/main/java/org/apache/geode/internal/cache/TXMessage.java > 08ce99ba1b58d2f80815807a97ab943589b64e5f > > geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java > 0de41bf7da6731df146749571bb3e951764a3444 > > geode-core/src/main/java/org/apache/geode/internal/cache/ha/HARegionQueue.java > 70224f2e4884cf9769ab9dce3b8c4a248aba7ef2 > > geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java > deb53cbc6efb081ac4da4d4b89be57d4899f46dc > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java > 3b0c2ff5786a8af13e9501ba4815335555f84319 > > geode-core/src/main/java/org/apache/geode/internal/cache/tx/ClientTXStateStub.java > ad3f103e5823cc8806e62ff0b240b8abbc77076a > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java > 1c94f9412bc957c5bf7b9c25170647758cedabea > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java > baa9d9c917e938dba132f3151f1ab47d37823820 > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/WANServiceProvider.java > 2aed0ee627551cd1a0b20832725eabe339470c9b > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java > adc967f7ab146d5d196c1b2a96799679e348c157 > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java > e6d54c58606dfa58d0a31ac2826aecbf9f1913bf > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/spi/WANFactory.java > 918c373f24d9b1ee603e857aee38a50c9bacbda3 > > geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java > b0b7d1b1b81b8dba8f395e4e2087d7d674800b87 > > geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/ParallelAsyncEventQueueCreation.java > 1e3429ccf6b150eba330ec9e5a7cc5628af2b8f7 > > geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/ParallelGatewaySenderCreation.java > 0dc6b829552dfc71f1aeea07f1b9ea1d6f2e3224 > > geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/SerialAsyncEventQueueCreation.java > 856ec3c257640c0c63f7007d40039c6e1e3513b8 > > geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/SerialGatewaySenderCreation.java > 7764c5875be9affe0ca2417b7457b026ca04ef0a > > geode-core/src/main/java/org/apache/geode/management/internal/LocalManager.java > 45916bca828598841ebb9cb52c59c3d2e8d51641 > > geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java > 5cbb990299f05f322f9c9398ff863cee886af573 > > geode-core/src/main/java/org/apache/geode/management/internal/beans/ManagementAdapter.java > 183a5a8a4df30828b900723708fc1ad832118ca2 > > geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBeanBridge.java > 1559aad31e11a8becc36d4c7e8ef1c1d384eb9f3 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java > 6dd5615727cd3f09a5d992c747f4aebdd7af8172 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DeployFunction.java > 148aa5f83ed9f3b329ecb2d942a74236b9e89b34 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java > 3ce1721cae8b75204787da2cedee6aab64d276b7 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunction.java > 171889856cb99dbf2e9e19ae6d190d6ac3c49e60 > > geode-core/src/main/java/org/apache/geode/pdx/internal/LonerTypeRegistration.java > b98f759fa40d1d7730cd1fd8009454b68eaf9f3b > > geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java > ed94c0c0a7c8087265fd920ac525dd327e14b3ee > > geode-core/src/test/java/org/apache/geode/cache/asyncqueue/internal/SerialAsyncEventQueueImplJUnitTest.java > 6e9c2d319bf4fdcfd66d9eaf9b5bf5fa911bad2c > geode-core/src/test/java/org/apache/geode/cache30/ReconnectDUnitTest.java > 68ef7f0e433431e7079e927b2e6d214f5cd82f4f > > geode-core/src/test/java/org/apache/geode/cache30/ReconnectedCacheServerDUnitTest.java > 2a2fe73e653daad5d1928a1dfe3fcdc716682f93 > > geode-core/src/test/java/org/apache/geode/cache30/TXDistributedDUnitTest.java > e268c22d619b654c2b3f40e9eb76a78256a9ead2 > > geode-core/src/test/java/org/apache/geode/internal/cache/BackupJUnitTest.java > 6d047732544aa9099cdd486b42007c2257a961f6 > > geode-core/src/test/java/org/apache/geode/internal/cache/NetSearchMessagingDUnitTest.java > 26412b22702467927829c628d809672f14879303 > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java > 66b19943e0679cc0c333d47db05d08e84771f6e6 > geode-core/src/test/java/org/apache/geode/test/fake/Fakes.java > 2ab64ddcc8944edc3741728dbad058316d21fbdd > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java > fe85efe089e9beea1e1e90c1de8308ef61c69e51 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java > d58f856b5f1a21d30111c302116b79774f2c2ae1 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImplFactory.java > 5da2732c64e089e12f6f8077301d5c2d98b5d6e5 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneRawIndex.java > f4518aa749adbe36b3814059d4bd055ed3e1b12e > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneRegionListener.java > 326c85c98be05780ed1eb867d59511d43474820a > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java > dbe24ff8c90cdf5b0c0cfa162e3929a3d2a8a8b1 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexFactorySpy.java > b3db8ec8561c0b5bceec65bd1379424b8268a462 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java > f2bfdd4efddfcdbb2f909b730ba2a3a3318ad323 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexImplJUnitTest.java > 10426619a701ed9fcd6b554cbe37155a41896bc1 > > geode-rebalancer/src/main/java/org/apache/geode/cache/util/AutoBalancer.java > 71d205161bf07b288b87131bd66e600a17cdcdd1 > > geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/WANFactoryImpl.java > a98510d389e5029e7b2d424a84e21235f8d619fb > > geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java > 68eb56ca58ce5f82632948f3455cb51429185a13 > > geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewayReceiverImpl.java > 8544636e1dc53cb2395afee62a721d4f99c81442 > > geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderFactoryImpl.java > 7398d29d57dd19ce1f86ca593a9ca9ebd6d6c700 > > geode-wan/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderImpl.java > 518966a7de2a858ce9c9ddc812b04ffc50ad3c0b > > geode-wan/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderImpl.java > 3aa18ce78b8afe68acf58648d428be41a2cb06a5 > > geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationDUnitTest.java > 8aa887b0412ae6446dc725d466bbd9ed6ad33f27 > > > Diff: https://reviews.apache.org/r/58484/diff/1/ > > > Testing > ------- > > precheckin in progress > full regression testing in progress > perf testing > > > Thanks, > > Kirk Lund > >
