----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58537/ -----------------------------------------------------------
Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe. Bugs: GEODE-2632 https://issues.apache.org/jira/browse/GEODE-2632 Repository: geode Description ------- GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies * extract fetching GemFireCacheImpl to Provider interface/class * use InternalCache instead of casting to Impl * delete useless javadocs and comments * reduce scope of constants, vars and methods * reorganize imports I know that CacheProviderImpl still uses GemFireCacheImpl.getExisting, but AbstractBaseController is now isolated from that so we can introduce better unit testing by providing a mock of InternalCache at a later date. I decided to package up the diff for geode-web-api as its own review and get it out of the way of the geode-core refactorings. Diffs ----- geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java 68080a3f27190eafb1541788b4f6bd6c93bd5346 geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java 89395425588abef7ff61a34aa30dfbe387342f89 geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java 62ce8609b437d02f43996cbb58d9fbbb33c9344e geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java e9b61f405c6c64f78551e137e1b98da02f920c4c geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java 3b08c5fafd85d9513395037e01453a5f1fc94667 geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java b00a7aa2d5d7439ba7c2d25fdd322448522cdf90 geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProvider.java PRE-CREATION geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProviderImpl.java PRE-CREATION Diff: https://reviews.apache.org/r/58537/diff/1/ Testing ------- precheckin in progress Thanks, Kirk Lund