----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58595/#review172682 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ShowMissingDiskStoresFunction.java Line 63 (original), 60 (patched) <https://reviews.apache.org/r/58595/#comment245736> Since `entry.getKey()` is not used, I think this can be simplified to: ``` for (Set<PersistentMemberID> entry : waitingRegions.values()) { for (PersistentMemberID id : entry) { memberMissingIDs.add(new PersistentMemberPattern(id)); } } ``` - Jared Stewart On April 20, 2017, 10:41 p.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58595/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 10:41 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kirk Lund, and Patrick > Rhomberg. > > > Repository: geode > > > Description > ------- > > This is a first pass review of the fix of gfsh hang on "show > missing-disk-stores" command when cache is initializing (i.e. waiting for a > missing disk-store). I'm working on a new DUnit test validate this change, > and will update the review when it's ready. > > GEODE-2681: refactoring to prevent synchronization hang on getAnyInstance > > In the JUnit test, renamed some variables to make things a more readable. > Also removed try/catches around unexpected Exceptions to let the testing > framework handle them. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ShowMissingDiskStoresFunction.java > a2812faa1f0310fd7e1861fe5c3623cb9ba79f97 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ShowMissingDiskStoresFunctionJUnitTest.java > 1cfa24270c3e4b6a59156c70d3ba478307af234a > > > Diff: https://reviews.apache.org/r/58595/diff/2/ > > > Testing > ------- > > Verified manually using the steps noted in GEODE-2798 (which is a dupilcate > of GEODE-2681.) > > Precheckin has been started. > > > Thanks, > > Ken Howe > >
