----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58238/#review172978 -----------------------------------------------------------
Fix it, then Ship it! Fix and Ship! geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java Lines 37 (patched) <https://reviews.apache.org/r/58238/#comment246025> Recommend private on these vars. - Kirk Lund On April 6, 2017, 9:12 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58238/ > ----------------------------------------------------------- > > (Updated April 6, 2017, 9:12 p.m.) > > > Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick > Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-2756: Do not put security-* properties in the env. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java > 9e051748f48b6d792724706535b120f1f4b0d1be > > geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorJUnitTest.java > 63d410f6335d9eabbb2547551e32dab8631c7871 > > geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java > 118e3853750d7ea3ef9af6ac092664a4dabb0108 > > > Diff: https://reviews.apache.org/r/58238/diff/1/ > > > Testing > ------- > > precheckin successful > > > Thanks, > > Jinmei Liao > >
