----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172981 -----------------------------------------------------------
Fix it, then Ship it! Fix and Ship! geode-core/src/test/java/org/apache/geode/test/dunit/rules/RestoreTCCLRule.java Lines 15 (patched) <https://reviews.apache.org/r/58518/#comment246028> This Rule looks useful outside of DUnit (like in an IntegrationTest). I recommend moving it from geode-core/src/test to geode-junit/src/main in package org.apache.geode.test.junit.rules. You could also create a Serializable version under org.apache.geode.test.junit.rules.serializable. In general I think dunit tests would use the Serializable flavor while any other test types would use the standard version. Just to confirm, this Rule only affects the main thread running in JUnit, right? - Kirk Lund On April 25, 2017, 6:20 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58518/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 6:20 p.m.) > > > Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir' > > - LocatorServerStarterRule will now always bounce the DUnit VMs in after() to > prevent corrupted cached values of `System.getProperty('user.dir')` that > refer to a temporary folder which no longer exists. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java > 2a3a7dd > > geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java > 1033b6c > geode-core/src/test/java/org/apache/geode/management/JMXMBeanDUnitTest.java > ebc3f17 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java > d47b343 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java > c5aaa74 > geode-core/src/test/java/org/apache/geode/test/dunit/VM.java 0b188ae > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/CleanupDUnitVMsRule.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > 34506c4 > geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberVM.java > 05e541a > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/RestoreTCCLRule.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58518/diff/4/ > > > Testing > ------- > > Precheckin started (still running) > > > Thanks, > > Jared Stewart > >
