----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58848/#review173358 -----------------------------------------------------------
Ship it! Ship It! - Jinmei Liao On April 28, 2017, 6:05 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58848/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 6:05 p.m.) > > > Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken > Howe, and Patrick Rhomberg. > > > Bugs: GEODE-2632 > https://issues.apache.org/jira/browse/GEODE-2632 > > > Repository: geode > > > Description > ------- > > Previous commit with refactorings of GemFireCacheImpl introduced this error: > > java.lang.ClassCastException: > org.apache.geode.cache.server.internal.ConnectionCountProbe cannot be cast to > org.apache.geode.lang.Identifiable > at > org.apache.geode.internal.cache.GemFireCacheImpl.addDeclarableProperties(GemFireCacheImpl.java:5076) > at > org.apache.geode.internal.cache.xmlcache.CacheCreation.create(CacheCreation.java:554) > at > org.apache.geode.internal.cache.xmlcache.CacheXmlParser.create(CacheXmlParser.java:343) > at > org.apache.geode.internal.cache.GemFireCacheImpl.loadCacheXml(GemFireCacheImpl.java:4243) > at > org.apache.geode.internal.cache.GemFireCacheImpl.initializeDeclarativeCache(GemFireCacheImpl.java:1388) > at > org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1189) > at > org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:756) > at > org.apache.geode.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:743) > at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:178) > at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:171) > at hydra.CacheHelper.createCacheFromXml(CacheHelper.java:193) > at > parReg.colocation.ParRegColocation.createRegionsWithXml(ParRegColocation.java:471) > at > parReg.colocation.ParRegColocation.initialize(ParRegColocation.java:394) > at > parReg.execute.FunctionServiceTest.HydraTask_HA_dataStoreInitialize(FunctionServiceTest.java:197) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at hydra.MethExecutor.execute(MethExecutor.java:182) > at hydra.MethExecutor.execute(MethExecutor.java:150) > at hydra.TestTask.execute(TestTask.java:192) > at hydra.RemoteTestModule$1.run(RemoteTestModule.java:212) > > This change restores the if-conditional back to its original format which > prevents the cast of ConnectionCountProbe. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > f3510dafa3da854317af32cadbb09cab9af98e4c > > > Diff: https://reviews.apache.org/r/58848/diff/1/ > > > Testing > ------- > > precheckin in progress > > > Thanks, > > Kirk Lund > >
