[
https://issues.apache.org/jira/browse/GEODE-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995982#comment-15995982
]
ASF GitHub Bot commented on GEODE-2754:
---------------------------------------
GitHub user nabarunnag opened a pull request:
https://github.com/apache/geode/pull/492
GEODE-2754: Changed the name of unknown host
* Assert failures occured if the network contained machines named
"unknown" as the test function also named the unknown host as "unknown"
* This led to test to find multiple machines named "unknown" rather
than one.
* Changed the name of the unknown host set by the test to be
"unknownGeodeHostWanAutoDiscoveryDUnitTest"
Potential reviewers:
@jhuynh1 @upthewaterspout @gesterzhou @ladyVader @boglesby
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2754
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/492.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #492
----
commit e2c50637e36d3a51abf4469d02c8843fff3b25fd
Author: nabarun <n...@pivotal.io>
Date: 2017-05-04T00:45:45Z
GEODE-2754: Changed the name of unknown host
* Assert failures occured if the network contained machines named
"unknown" as the test function also named the unknown host as "unknown"
* This led to test to find multiple machines named "unknown" rather
than one.
* Changed the name of the unknown host set by the test to be
"unknownGeodeHostWanAutoDiscoveryDUnitTest"
----
> CI failure: WanAutoDiscoveryDUnitTest
> -------------------------------------
>
> Key: GEODE-2754
> URL: https://issues.apache.org/jira/browse/GEODE-2754
> Project: Geode
> Issue Type: Bug
> Components: wan
> Reporter: Bruce Schuchardt
>
> Two new tests in this class fail if the network happens to have a machine
> named "unknown".
> {noformat}
> :geode-wan:distributedTest
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest >
> testValidAndInvalidHostRemoteLocators FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest$$Lambda$1538/701582275.run
> in VM 2 running on Host trout.gemstone.com with 8 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
> at
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.testRemoteLocators(WanAutoDiscoveryDUnitTest.java:645)
> at
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.testValidAndInvalidHostRemoteLocators(WanAutoDiscoveryDUnitTest.java:622)
> Caused by:
> java.lang.AssertionError: expected:<1> but was:<2>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.geode.internal.cache.wan.WANTestBase.verifyPool(WANTestBase.java:3446)
> at
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.lambda$testRemoteLocators$1f02559b$1(WanAutoDiscoveryDUnitTest.java:645)
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest >
> testInvalidHostRemoteLocators FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest$$Lambda$1538/701582275.run
> in VM 2 running on Host trout.gemstone.com with 8 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
> at
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.testRemoteLocators(WanAutoDiscoveryDUnitTest.java:645)
> at
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.testInvalidHostRemoteLocators(WanAutoDiscoveryDUnitTest.java:611)
> Caused by:
> java.lang.AssertionError: expected null, but was:<PoolImpl@41046873
> name=ln>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotNull(Assert.java:755)
> at org.junit.Assert.assertNull(Assert.java:737)
> at org.junit.Assert.assertNull(Assert.java:747)
> at
> org.apache.geode.internal.cache.wan.WANTestBase.verifyPool(WANTestBase.java:3448)
> at
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.lambda$testRemoteLocators$1f02559b$1(WanAutoDiscoveryDUnitTest.java:645)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
