[ https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003099#comment-16003099 ]
ASF GitHub Bot commented on GEODE-2900: --------------------------------------- GitHub user jhuynh1 opened a pull request: https://github.com/apache/geode/pull/502 GEODE-2900: push shadow key to the front of eventSeqNumQueue Testing still needs to be done on this change, but wanted to get some eyeballs on the change in parallel @upthewaterspout @boglesby You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/geode feature/GEODE-2900 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/502.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #502 ---- commit 240b469ff217fbfba39381f196ae3e0e832a69a6 Author: Jason Huynh <huyn...@gmail.com> Date: 2017-05-09T17:11:39Z GEODE-2900: push shadow key back into the front of the eventSeqNumber "Queue" ---- > BucketRegionQueue transitions from primary/secondary/primary can lead to > events lingering in queue > -------------------------------------------------------------------------------------------------- > > Key: GEODE-2900 > URL: https://issues.apache.org/jira/browse/GEODE-2900 > Project: Geode > Issue Type: Bug > Components: wan > Reporter: Jason Huynh > Assignee: Jason Huynh > > In this scenario when peek() is called from BucketRegionQueue, a side effect > is that the key is removed from the eventSeqNumQueue and an event is placed > into the peekedEvents list. > If there is failure dispatching the event, we add the peekedEvents list to a > new peekedEvents list. Before doing so, we remove any events that we are not > primary for. Now the event is not in the eventSeqNumQueue or the > peekedEvents list > If we now become primary (before the other node could dispatch this event), > and because we do not have that event in the eventSeqNumQueue or the > peekedEvents, it gets "stuck." -- This message was sent by Atlassian JIRA (v6.3.15#6346)