[
https://issues.apache.org/jira/browse/GEODE-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004628#comment-16004628
]
ASF GitHub Bot commented on GEODE-2890:
---------------------------------------
GitHub user ameybarve15 opened a pull request:
https://github.com/apache/geode/pull/505
[GEODE-2890]: Corrected debug log location in
AbstractGatewaySenderEventProcessor.processQueue().
Corrected debug log location in
AbstractGatewaySenderEventProcessor.processQueue().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ameybarve15/incubator-geode feature/GEODE-2890
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/505.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #505
----
commit a787737f9ad6656e7da382b35c49ecf622900bf0
Author: Amey Barve <aba...@apache.org>
Date: 2017-05-10T09:17:30Z
GEODE-2890: Corrected debug log location in
AbstractGatewaySenderEventProcessor.processQueue().
----
> Incorrect debug log location in
> AbstractGatewaySenderEventProcessor.processQueue()
> -----------------------------------------------------------------------------------
>
> Key: GEODE-2890
> URL: https://issues.apache.org/jira/browse/GEODE-2890
> Project: Geode
> Issue Type: Bug
> Components: wan
> Reporter: Jason Huynh
> Assignee: Amey Barve
>
> The following code snippet in processQueue() for AEQ's appears to be outside
> of an if condition where we check to see if the node is primary still or not.
> This line prints for every event and I believe it should be inside the
> previous if condition.
> {noformat}
> if (qpr != null) {
> BucketRegion bucket = qpr.getDataStore().getLocalBucketById(bucketId);
> if (bucket == null || !bucket.getBucketAdvisor().isPrimary()) {
> event.setPossibleDuplicate(true);
> //I think the debug log should be placed here?
> }
> }
> if (isDebugEnabled) {
> logger.debug( "Bucket id: {} is no longer primary on this node. The event
> {} will be dispatched from this node with possibleDuplicate set to true.",
> bucketId, event);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
