[
https://issues.apache.org/jira/browse/GEODE-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008098#comment-16008098
]
ASF GitHub Bot commented on GEODE-2637:
---------------------------------------
GitHub user nabarunnag opened a pull request:
https://github.com/apache/geode/pull/512
GEODE-2637: Refactored LuceneQueryFactory.setResultLimit()
* Renamed LuceneQueryFactory.getResult to setLimit()
* This is done to match the cwiki documents
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2637
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/512.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #512
----
commit efbe53cbafe30c5fb17681e22a3c83f3042e08ae
Author: nabarunnag <n...@cs.wisc.edu>
Date: 2017-05-12T13:01:01Z
GEODE-2637: Refactored LuceneQueryFactory.setResultLimit()
* Renamed LuceneQueryFactory.getResult to setLimit()
* This is done to match the cwiki documents
----
> LuceneQueryFactory.setResultLimit() method should match LuceneQuery.getLimit()
> ------------------------------------------------------------------------------
>
> Key: GEODE-2637
> URL: https://issues.apache.org/jira/browse/GEODE-2637
> Project: Geode
> Issue Type: Bug
> Components: lucene
> Affects Versions: 1.2.0
> Reporter: Shelley Lynn Hughes-Godfrey
> Assignee: Shelley Lynn Hughes-Godfrey
>
> In the Lucene docs located here:
> https://cwiki.apache.org/confluence/display/GEODE/Text+Search+With+Lucene
> we see that we control the number of results from the lucene query via
> LuceneQueryFactory.setLimit() which corresponds directly with the
> LuceneQuery.getLimit() method.
> However, this has been implemented as LuceneQueryFactory.setResultLimit().
> This needs to be changed to setLimit().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
