[
https://issues.apache.org/jira/browse/GEODE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014615#comment-16014615
]
ASF GitHub Bot commented on GEODE-2662:
---------------------------------------
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/500#discussion_r117080378
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
---
@@ -406,124 +400,140 @@ public Result toCommandResult() {
section.addData("Message", errorString);
section.addData(RESULT_FLAG, operationCompletedSuccessfully);
return ResultBuilder.buildResult(data);
+ }
+
+ CompositeResultData data = ResultBuilder.createCompositeResultData();
+ SectionResultData section = data.addSection();
+ TabularResultData table = section.addTable();
+
+ section.addData(RESULT_FLAG, operationCompletedSuccessfully);
+ if (infoString != null) {
+ section.addData("Message", infoString);
+ }
+
+ if (isGet()) {
+ toCommandResult_isGet(section, table);
+ } else if (isLocateEntry()) {
+ toCommandResult_isLocate(section, table);
+ } else if (isPut()) {
+ toCommandResult_isPut(section, table);
+ } else if (isRemove()) {
+ toCommandResult_isRemove(section, table);
+ } else if (isSelect()) {
+ // its moved to its separate method
--- End diff --
so, for isSelect() we don't do anything? looks like isSelect() is only used
here, probably we can remove this function? looks like there is a lot of unused
functions in this class as well.
> Gfsh displays field value on wrong line!
> ----------------------------------------
>
> Key: GEODE-2662
> URL: https://issues.apache.org/jira/browse/GEODE-2662
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Eitan Suez
> Assignee: Patrick Rhomberg
>
> scenario:
> start a locator, a server
> write a client that stores several records of a given type, using pdx
> serialization
> modify the type in question by adding a field
> write one more record to gemfire, populating all fields, including the new
> field
> invoke a gfsh query command "select * from /<Region>"
> the new field value will display always on the first line of the result set,
> not on the line associated with the object it actually belongs to.
> example:
> Customer
> firstName, lastName
> write a customer object:
> John Doe
> now modify Customer, add telephoneNumber
> write another customer object:
> Sam Smith, 512.333.4444
> now run:
> query --query="select c from /Customer c"
> will print:
> firstName | lastName | telephoneNumber
> --------- | -------- | ---------------
> John | Doe | 512.333.4444
> Sam | Smith | null
> even though the query "select c from /Customer c where c.firstName = 'Sam'"
> clearly shows the phone number is associated with sam.
> this bug has existed in gemfire at least since v8 and verified to still exist
> in latest version 9.0.1
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
