GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/520
GEODE-2582: New client can send a Put request with Protobuf IDL.
* Update the proto IDL
* Get a put request working.
Currently this only uses String serialization; serialization protocols
still have to be implemented.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
--> It does, except for `testRedundancySatisfactionPreferRemoteIp`, which
I have seen fail on my machine before for some reason related to my network
config.
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
@metatype can you verify that this license is compatible?
https://github.com/google/protobuf/blob/master/LICENSE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/galen-pivotal/geode feature/GEODE-2582
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/520.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #520
----
commit e7499a892e05fc6f2151310ea088261ffa4966af
Author: Galen OSullivan <[email protected]>
Date: 2017-03-16T23:26:03Z
GEODE-2582: New client can send a Put request with Protobuf IDL.
* Update the proto IDL
* Get a put request working.
Currently this only uses String serialization; serialization protocols
still have to be implemented.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
