[ 
https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020642#comment-16020642
 ] 

ASF GitHub Bot commented on GEODE-269:
--------------------------------------

GitHub user deepakddixit opened a pull request:

    https://github.com/apache/geode/pull/526

    GEODE-269 :  Removing deprecated API's from FunctionService.

    Modified test cases after removing deprecated API's
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
    Yes.GEODE-269
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    Yes
    - [x] Does `gradlew build` run cleanly?
    Yes
    - [x] Have you written or updated unit tests to verify your changes?
    Updated existing test cases.
    - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    No new dependencies added
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
    submit an update to your PR as soon as possible. If you need help, please 
send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/deepakddixit/incubator-geode GEODE-269

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/526.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #526
    
----
commit 4d1663fde42272dcb730d490afe553725442ef37
Author: Deepak Dixit <deepakdixit2...@gmail.com>
Date:   2017-05-23T04:17:13Z

    GEODE-269 :  Removing deprecated API's from FunctionService.
    Modified test cases after removing deprecated API's

----


> Remove deprecated methods on FunctionService
> --------------------------------------------
>
>                 Key: GEODE-269
>                 URL: https://issues.apache.org/jira/browse/GEODE-269
>             Project: Geode
>          Issue Type: Sub-task
>            Reporter: Darrel Schneider
>            Assignee: Deepak Dixit
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> FunctionService has a three deprecated methods that should be easy to remove. 
> All the deprecated methods have a DistributedSystem parameter. New flavors of 
> these methods exist that do not take the DistributedSystem since it is known 
> implicitly by the FunctionService.
> Many tests use the deprecated methods but it should be easy to change them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to