[
https://issues.apache.org/jira/browse/GEODE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022644#comment-16022644
]
ASF GitHub Bot commented on GEODE-2981:
---------------------------------------
GitHub user masaki-yamakawa opened a pull request:
https://github.com/apache/geode/pull/530
GEODE-2981: Fix the line feed code of the test expected value
Fixed the line feed code of the test expectation value so that it does not
depend on the runtime environment.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masaki-yamakawa/geode feature/GEODE-2981
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/530.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #530
----
commit a93abb4c7761a1795bef9e4e411fd0f3a5905302
Author: masaki.yamakawa <[email protected]>
Date: 2017-05-24T09:29:46Z
GEODE-2981: Fix the line feed code of the test expected value
Fixed the line feed code of the test expectation value so that it does
not depend on the runtime environment.
----
> Fix the line feed code of the test expected value
> -------------------------------------------------
>
> Key: GEODE-2981
> URL: https://issues.apache.org/jira/browse/GEODE-2981
> Project: Geode
> Issue Type: Test
> Components: tests
> Reporter: Masaki Yamakawa
> Priority: Minor
>
> I mainly use the Windows. When I run the test on Windows, because Assertion
> fails due to the difference in line feed code, I want to change this so that
> it does not depend on the runtime environment.
> The target classes are as follows:
> - org.apache.geode.management.internal.cli.shell.GfshJunitTest
> - org.apache.geode.management.internal.cli.help.HelpBlockUnitTest
> - org.apache.geode.management.internal.cli.help.HelperUnitTest
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
