----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59546/#review176113 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java Line 196 (original), 196 (patched) <https://reviews.apache.org/r/59546/#comment249446> Removed it. here we validate hist only geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java Line 277 (original), 281 (patched) <https://reviews.apache.org/r/59546/#comment249447> Removed commented code geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java Line 1555 (original), 1555 (patched) <https://reviews.apache.org/r/59546/#comment249448> This is just for compare purpose. geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java Line 131 (original), 132 (patched) <https://reviews.apache.org/r/59546/#comment249449> Yes, that's the change.Removed commented code geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java Lines 234 (patched) <https://reviews.apache.org/r/59546/#comment249453> line 131; but then hostname will be there. What I am reading is that at this point either host/hostname will be there geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java Lines 278 (patched) <https://reviews.apache.org/r/59546/#comment249451> Ip should be fine. This can throw exception when host/hostname is not appropriate. geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java Lines 346 (patched) <https://reviews.apache.org/r/59546/#comment249452> If locator host is still not avialable then server won't be able to join the cluster. - Hitesh Khamesra On May 25, 2017, 7:06 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59546/ > ----------------------------------------------------------- > > (Updated May 25, 2017, 7:06 p.m.) > > > Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > ------- > > We configure locator list to start the cache. This locator list is validated > while creating the cache. We verify whether locator host exist or not. Now we > have remove this verification as in cloud environment host may not available > for time being. > > Patch from Bruce. Modified couple of tests. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java > c1bfc93 > > geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java > 01c6157 > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java > 7caad3f > > geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java > 5ab1bed > > geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java > 1dc2fd1 > > geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java > dc73f04 > > geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java > 9f6c5fb > > geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt > 9cff80d > > geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java > d6d5d7c > > > Diff: https://reviews.apache.org/r/59546/diff/2/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
