[
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025235#comment-16025235
]
ASF GitHub Bot commented on GEODE-2957:
---------------------------------------
GitHub user DivineEnder opened a pull request:
https://github.com/apache/geode/pull/537
GEODE-2957: Added DEFAULT as a standardAnalyzer keyword specifier whe…
…n creating Lucene index
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DivineEnder/geode feature/GEODE-2957
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/537.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #537
----
commit 7b0543a7325ee08fb9b91710c9b406cc41f75451
Author: David Anuta <[email protected]>
Date: 2017-05-25T19:03:43Z
GEODE-2957: Added DEFAULT as a standardAnalyzer keyword specifier when
creating Lucene index
----
> null used as a default parameter when specifying analyzers
> ----------------------------------------------------------
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
> Issue Type: Bug
> Components: lucene
> Reporter: Jason Huynh
>
> null seems to be the way to specify using the default
> StandardKeywordAnalyzer. This can be used when specifying a long list of
> field/analyzers.
> So the line may look like
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
> We should probably change that to default or some other keyword. null seems
> a bit confusing.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
