[
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030267#comment-16030267
]
ASF GitHub Bot commented on GEODE-2203:
---------------------------------------
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119231037
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
---
@@ -2747,6 +2749,8 @@
public static final String STATUS_SERVER__DIR = "dir";
public static final String STATUS_SERVER__DIR__HELP =
"Working directory in which the Cache Server is running. The default
is the current directory.";
+ public static final String
STATUS_SERVER__NO_SERVER_SPECIFIED_ERROR_MESSAGE =
--- End diff --
I believe the `running in %2$s` portion of this output is going to be
misleading when the status locator command has omitted the `workingDirectory`
option. For example, if I ask for the status of a remote locator by specifying
its hostname and port, this message will suggest that we expect the locator to
be running in the current directory on the GFSH client machine. It might also
be helpful for this message to explain *why* we are unable to determine the
status of this Locator. Maybe something like "At least one of the following
options must be specified: `--name`, `--host`, or `--port`. Use 'help status
server' to display detailed usage information." would be more helpful.
> gfsh status locator/server - Give more descriptive output on empty parameter
> ----------------------------------------------------------------------------
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Alyssa Kim
> Assignee: Emily Yeh
> Priority: Minor
> Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters
> gives a vague explanation/output that might be misleading. Although we have
> help <command_name> for usage description, displaying 'null' as an output
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
> on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
