[ 
https://issues.apache.org/jira/browse/GEODE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033267#comment-16033267
 ] 

ASF subversion and git services commented on GEODE-2966:
--------------------------------------------------------

Commit ad48ab684c007b5996a942d12d63c5f405ba03f7 in geode's branch 
refs/heads/develop from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ad48ab6 ]

GEODE-2966: Restore command changes lost in merge conflict


> Refactor LauncherLifecycleCommands
> ----------------------------------
>
>                 Key: GEODE-2966
>                 URL: https://issues.apache.org/jira/browse/GEODE-2966
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh, management
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>             Fix For: 1.3.0
>
>
> LauncherLifecycleCommands is over 2000 lines of code, and could be made a lot 
> more readable by introducing proper OO abstraction.  There are also many 
> private static final strings like {{CliStrings.START_LOCATOR__MEMBER_NAME}} 
> that could be made shorter and more contextual, e.g. 
> {{StartLocatorCommand.MEMBER_NAME}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to