[
https://issues.apache.org/jira/browse/GEODE-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036284#comment-16036284
]
ASF GitHub Bot commented on GEODE-3028:
---------------------------------------
GitHub user masaki-yamakawa opened a pull request:
https://github.com/apache/geode/pull/556
GEODE-3028: Fix the expected value of the test that depended on Locale
Fix the test that uses the English message as the expected value so that it
does not depend on the locale at runtime environment.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masaki-yamakawa/geode feature/GEODE-3028
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/556.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #556
----
commit 0ee38f3ac60d50d16297343a330024e4c8afc133
Author: masaki.yamakawa <masaki.yamak...@ulsystems.co.jp>
Date: 2017-05-28T23:17:10Z
GEODE-3028: Fix the expected value of the test that depended on Locale
Fix the test that uses the English message as the expected value so that
it does not depend on the locale at runtime environment.
----
> Fix the expected value of the test that depended on Locale
> ----------------------------------------------------------
>
> Key: GEODE-3028
> URL: https://issues.apache.org/jira/browse/GEODE-3028
> Project: Geode
> Issue Type: Test
> Components: tests
> Reporter: Masaki Yamakawa
> Priority: Minor
>
> I am testing in Japanese environment. Running the test in the Japanese
> environment will cause the Assertion to fail due to the difference in Locale,
> so I want to change this so that it does not depend on the runtime
> environment.
> The target classes are as follows:
> -
> org.apache.geode.distributed.internal.membership.gms.auth.GMSAuthenticatorWithAuthenticatorTest
> -
> org.apache.geode.distributed.internal.membership.gms.auth.GMSAuthenticatorWithSecurityManagerTest
> - org.apache.geode.internal.cache.tier.sockets.ServerConnectionTest
> - org.apache.geode.internal.cache.ColocationHelperTest
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
