----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59904/#review177311 -----------------------------------------------------------
Ship it! Ship It! - Jinmei Liao On June 8, 2017, 12:03 a.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59904/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 12:03 a.m.) > > > Review request for geode and Bruce Schuchardt. > > > Bugs: GEODE-3050 > https://issues.apache.org/jira/browse/GEODE-3050 > > > Repository: geode > > > Description > ------- > > GEODE-3050: prevent empty dat files > > Move creation of dat files to test methods to avoid overwriting > full dat file from other test. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java > dc73f04309d36fec79558914a81f5eddcbbbe5a9 > > > Diff: https://reviews.apache.org/r/59904/diff/1/ > > > Testing > ------- > > 1) AnalyzeSerializablesJUnitTest, AnalyzeCQSerializablesJUnitTest, > AnalyzeWANSerializablesJUnitTest > 2) precheckin in progress > > > Thanks, > > Kirk Lund > >
