----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59924/#review177348 -----------------------------------------------------------
Ship it! If precheckin passes... Ship it.. - Udo Kohlmeyer On June 8, 2017, 5:54 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59924/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 5:54 p.m.) > > > Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > ------- > > There was conflict in "LauncherLifecycleCommands", this code moved to > "ClusterConfigurationStatusRetriever". > > We are reverting this issue as we cache InetAddress in geode. But caching > "hostname" is causing various issuess. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java > 070451c > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 84d42cf > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java > e9476b5 > > geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java > eb71d38 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > 4c668b6 > > geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/ClusterConfigurationStatusRetriever.java > 9f35edd > > geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java > 9ceb461 > > > Diff: https://reviews.apache.org/r/59924/diff/1/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
