----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59905/#review177377 -----------------------------------------------------------
Fix it, then Ship it! Fix the test category on LauncherLifecycleCommandsTest and ship it! geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java Lines 2370 (patched) <https://reviews.apache.org/r/59905/#comment250923> At first I thought this was a HOSTNAME for the client itself. Maybe reword to: "Hostname provided to clients from the locator for the location of a JMX Manager." geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java Lines 39 (patched) <https://reviews.apache.org/r/59905/#comment250925> This should be an IntegrationTest since it uses TemporaryFolder. - Kirk Lund On June 8, 2017, 5:33 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59905/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 5:33 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-2933: Add jmx-manager-hostname-for-clients for startLocator and > startServer > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java > df16e9b > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > 4c668b6 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > 9f68d3a > > geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java > c2c6e14 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java > c5ff6b6 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserAutoCompletionTest.java > a122de0 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserConverterTest.java > 1ff60d6 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java > ab6dc3d > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshParserRule.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59905/diff/2/ > > > Testing > ------- > > Precheckin passed (other than 1 known flaky) > > > Thanks, > > Jared Stewart > >
