GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/582
GEODE-2601: Fix banner being logged twice
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-2601)
The banner (see `Banner.java`) was being logged twice every time a locator
was started up in gfsh. The cause was that both locators (see
`InternalLocator.java`) and distributed systems (see
`InternalDistributedSystem.java`) contained code to log the banner because
previously, it was possible for locators and distributed systems to exist
without each other. However, now, since the locators started up by gfsh will
always be part of a distributed system, code for logging the banner during
locator startup was removed, and code for logging the banner during distributed
system startup was retained.
**_Precheckin status: Mostly green with a few unrelated failures_**
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-2601
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/582.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #582
----
commit 708f39feef403055a539ca74d49f1ab4313cb430
Author: YehEmily <emilyyeh1...@gmail.com>
Date: 2017-06-08T21:40:39Z
GEODE-2601: Fixing banner being logged twice during locator startup (now
only logs once if both locator and distributed systems are started)
commit 5ebaef30821f6d123d67fe983313ced6563aeacd
Author: YehEmily <emilyyeh1...@gmail.com>
Date: 2017-06-12T20:55:24Z
GEODE-2601: Fixing banner being logged twice during locator startup.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
