Github user jhuynh1 commented on a diff in the pull request:

    https://github.com/apache/geode/pull/588#discussion_r123060011
  
    --- Diff: 
geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
 ---
    @@ -510,6 +512,16 @@ public void 
testCreateAsyncIndexWhileDoingGIIAndCompareQueryResults() throws Exc
         vm1.invoke(prIndexCreationCheck(PERSISTENT_REG_NAME, "secIndex", 50));
         vm1.invoke(indexCreationCheck(REP_REG_NAME, "secIndex"));
     
    +    vm1.invoke(() -> Awaitility.await().atMost(60, 
TimeUnit.SECONDS).until(() -> {
    +      boolean regionSizeCheck = getCache().getRegion(NAME).size() == 500
    +          && getCache().getRegion(REP_REG_NAME).size() == 500
    --- End diff --
    
    Shouldn't this clause check the index size and not the region size?  I 
would think the timing issue was because the indexes were async.  Because of 
the async, the indexes may not have processes all of the updates prior to 
validating the contents of the index...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to