GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/597
Client protocol with develop, gated by a feature flag.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [there are two. This is a combination of #593 and #586 ] Is there a JIRA
ticket associated with this PR? Is it referenced in the commit message?
- [no. It was merged.] Has your PR been rebased against the latest commit
within the target branch (typically `develop`)?
- [no.] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/galen-pivotal/geode
client-protocol-with-develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/597.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #597
----
commit 61b2c2746ea7128a5aafec7469c23fc6417f283a
Author: Galen OSullivan <[email protected]>
Date: 2017-06-12T16:33:35Z
GEODE-3075: Initial refactor adding NewProtocolServerConnection
subclassing `ServerConnection`.
The new code is broken but it won't be called under normal operation,
since it's gated on a system property, "geode.feature-protobuf-protocol"
Further refactoring and feature work to come.
commit 649f4d31fd78d5301c13d29f7cd10481fda824b2
Author: Galen OSullivan <[email protected]>
Date: 2017-06-16T16:59:11Z
GEODE-3075: Add an integration test for the ServerConnectionFactory
the current implementation is bogus, but does test that the flow works.
commit 51b6ee1a817f48c924e5beefaaf2329cf33ed612
Author: Udo Kohlmeyer <[email protected]>
Date: 2017-06-12T22:12:18Z
GEODE-2995: Handle stream of ProtoBuf encoded messages
This for now exists in isolation, but will be hooked up with the code
currently in review for GEODE-3075
Signed-off-by: Alexander Murmann <[email protected]>
Signed-off-by: Brian Rowe <[email protected]>
commit 11184afd39f1b160d7c2b208badc2bdce2644047
Author: Galen OSullivan <[email protected]>
Date: 2017-06-20T00:48:53Z
GEODE-3075: changes in response to feedback; refactor some.
`AcceptorImpl.handleNewClientConnection` has had refactoring and should
be a bit more understandable.
commit 5fe955251ae3428da457b88a69dae51785a1d6e3
Author: Brian Rowe <[email protected]>
Date: 2017-06-20T22:49:11Z
GEODE-2995: Implementing review feedback
Numerous tweaks and fixes
Created protobuf package under org.apache.geode.protocol and moved several
classes
Added javadoc comments
Signed-off-by: Galen O'Sullivan <[email protected]>
commit 4aefd603f6d530114a9a7b8a0eced71941cf20fe
Author: Galen O'Sullivan <[email protected]>
Date: 2017-06-20T23:58:51Z
GEODE-2995: more review feedback and spotlessApply
Signed-off-by: Brian Rowe <[email protected]>
commit 609343e0c44b5c2dffc8b02f0b3cde775a4199e5
Author: Brian Rowe <[email protected]>
Date: 2017-06-21T18:53:54Z
GEODE-2995: incorporating even more review feedback
Addressing feedback from Udo and Hitesh
Refactored test locations to match new src layout
Signed-off-by: Galen O'Sullivan <[email protected]>
Signed-off-by: Brian Rowe <[email protected]>
commit fea517b52400353ef766bdc97224e142558c01e8
Author: Galen OSullivan <[email protected]>
Date: 2017-06-21T21:01:01Z
GEODE-3075: fix an integration test.
I think the test fails because another test doesn't clean up system
properties when it's done.
commit 06c77ae34388e535ba0b06b2a9a3af9929f98338
Author: Galen OSullivan <[email protected]>
Date: 2017-06-21T21:25:23Z
Merge branch 'develop' into merge
commit 22c1d75126abb1bb83d64d38dec1ca48051acb72
Author: Galen OSullivan <[email protected]>
Date: 2017-06-21T21:25:29Z
Merge remote-tracking branch 'wirebaron/feature/GEODE-2995' into merge
commit 71535a0bed01aa9d18d545cadcb826164c97986f
Author: Galen OSullivan <[email protected]>
Date: 2017-06-21T23:53:03Z
merge GEODE-2995, GEODE-3775 into develop with integration test.
Signed-off-by: Brian Rowe <[email protected]>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
