Github user PurelyApplied commented on a diff in the pull request:

    https://github.com/apache/geode/pull/596#discussion_r123829882
  
    --- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
 ---
    @@ -57,7 +56,48 @@ public void setUp() throws Exception {
       }
     
       @Test
    -  @ConnectionConfiguration(user = "data-admin", password = "1234567")
    +  @ConnectionConfiguration(user = "clusterRead", password = "clusterRead")
    +  public void testClusterReadAccess() throws Exception {
    +    assertThatThrownBy(() -> 
bean.flush()).hasMessageContaining(TestCommand.diskManage.toString());
    --- End diff --
    
    Thank you regex.  Done and done in commit `97de2f3`.
    For what it's worth / future reference, `s/\(\) -> 
(\w+)\.(\w+)\(\)\)/$1::$2\)` would make 3,232 test replacements, but hits no 
production files, so that's nice.  Maybe something to add to spotless down the 
line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to