Github user echobravopapa commented on the issue:

    https://github.com/apache/geode-native/pull/106
  
    @gregt5259 a couple quick items of feedback that need to be addressed 
before this is reviewed:
    
    - please squash your commits, this cleans up the diffs for everyone to 
better review your contribution
    please close [#105](https://github.com/apache/geode-native/pull/105) as 
duplicate of this PR
    - please have a look at the [Code 
Contribution](https://cwiki.apache.org/confluence/display/GEODE/Code+contributions)
 section of the WIKI
    -- for one you will see that we are using GitFlow and your PR should be 
coming in from a feature branch (e.g.  feature/GEODE-2891) instead of your 
develop branch
    
     Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to