----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review179785 -----------------------------------------------------------
For the record, and as discussed offline, I think 1-arg method should be marked as @Deprecated for the upcoming release rather than immediately removing it. Removing the @Deprecated annotation on the 3-arg method is appropriate as this is now the preferred method. - Ken Howe On July 5, 2017, 7:47 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60666/ > ----------------------------------------------------------- > > (Updated July 5, 2017, 7:47 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > geode-3166: remove the uncalled getCredential method > > I simply removed the call. Since the new method is never called, if we have > any users that's implementing this method, it's never used anyway. We will > not be breaking backward compatibility, I believe. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java > 6b0675a5629a3e057fd3d54841db740189007966 > > > Diff: https://reviews.apache.org/r/60666/diff/1/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >
