----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60977/#review180949 -----------------------------------------------------------
Ship it! Ship It! - Jinmei Liao On July 19, 2017, 5:14 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60977/ > ----------------------------------------------------------- > > (Updated July 19, 2017, 5:14 p.m.) > > > Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, > and Patrick Rhomberg. > > > Bugs: GEODE-3251 > https://issues.apache.org/jira/browse/GEODE-3251 > > > Repository: geode > > > Description > ------- > > GEODE-3251: make JMX test rules more robust > > Add "Failed to retrieve RMIServer stub" to rule await > to help ensure that JMX RMI is ready before running > the test. > > Also removed Soft assertions from DiskStoreMXBeanSecurityJUnitTest. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java > 4d101e7862dd45bbf4faaec84cb4f808cfd26cf3 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > 872553efed290890708caaf98dc206b4735005d0 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/MBeanServerConnectionRule.java > 3addc4e2ff07d36a340ed548e4c9a2d7f6094390 > > > Diff: https://reviews.apache.org/r/60977/diff/1/ > > > Testing > ------- > > DiskStoreMXBeanSecurityJUnitTest > precheckin in progress > > > Thanks, > > Kirk Lund > >
