Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/676#discussion_r130920986
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License), Version 2.0
+ * (the "License")), you may not use this file except in compliance with
the License. You may obtain
+ * a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE2.0
+ *
+ * Unless required by applicable law or agreed to in writing), software
distributed under the
+ * License is distributed on an "AS IS" BASIS), WITHOUT WARRANTIES OR
CONDITIONS OF ANY KIND),
+ * either express or implied. See the License for the specific language
governing permissions and
+ * limitations under the License.
+ */
+package org.apache.geode.protocol.protobuf;
+
+public enum ProtocolErrorCode {
+ GENERIC_FAILURE(1000),
--- End diff --
This originally started at "1" and was followed by "100". After I protested
it was changed to "001". After more discussion we ended up with the "1000" and
"2000" ranges to accommodate for sub-ranges.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
