Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131290142
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRequestProcessor.java
---
@@ -196,6 +196,13 @@ long getLeaseExpireTime() {
return this.response.leaseExpireTime;
}
+ /**
+ *
+ * @param interruptible
+ * @param lockId
+ * @return
+ * @throws InterruptedException only possible if interruptible is true.
+ */
protected boolean requestLock(boolean interruptible, int lockId) throws
InterruptedException {
final boolean isDebugEnabled_DLS =
logger.isTraceEnabled(LogMarker.DLS);
--- End diff --
The `LogMarker` is used in the `logger.trace` function. This is based on an
old pattern that was written because an old version of the logger was slow, so
it was better to gate on a boolean for performance. The logging function will
do an identical check to this one before printing a log message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
