----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61426/ -----------------------------------------------------------
Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, and Patrick Rhomberg. Repository: geode Description ------- Updated tests for changes in the error constructors for ServerState and LocatorState. Minor refactorings and spelling corrections to improve code clarity. Some error results from gfsh 'status locator' and 'server loccator' commands returned a messge of "null", or in some cases woudl throw a NumberFormatException. These results were due to constructors for LocatorLauncher.LocatorState and ServerLauncher.ServerState filling relevant fields with nulls. This change sets the fields in the ...State instances to values available through the command being executed. The affect constructors are only used for building error results for the status commands. Diffs ----- geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java 3a98373938e3de21da6badcf460dae3648218ac6 geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java c5a2de88086e92dfc9b35d764b88ff8c8e524853 geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 158e7bf45a3cb72f6b96345810b935096b44ee7e geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusLocatorCommand.java 06f835034c32e7c6cc7a11d9657d8b5d40d0f2d8 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusServerCommand.java 43374ab161b67357d2f8b2987d7656156cbc12c1 geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteIntegrationTest.java 47e512a2dc3a8780dd941af8309865c4f1dbf36f geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/GfshStatusCommandsIntegrationTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java e7f17ef208a1708f385c7c4041affb70fd309a4c Diff: https://reviews.apache.org/r/61426/diff/1/ Testing ------- Precheckin ran green Thanks, Ken Howe
