GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/687
GEODE-3258: Refactoring DiskStoreCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3258)
`DiskStoreCommands` was a huge class that contained a large number of
commands. These commands have been split into their own individual command
classes. Two methods shared by several commands were moved into
`DiskStoreCommandsUtils` (it has been mentioned before that --Utils classes
should be avoided, but because a better home for these methods could not be
found, this issue may be resolved later in the future).
Some tests were also updated - `DiskStoreCommandsJUnitTest` and
`ListAndDescribeDiskStoreCommandsDUnitTest`. It really looks like the two tests
share many of the same functionalities... I think that
`ListAndDescribeDiskStoreCommandsDUnitTest` could be removed, since
`DiskStoreCommandsJUnitTest` already seems to test `ListDiskStoreCommand` and
`DescribeDiskStoreCommand`, and `DiskStoreCommandsJUnitTest` should be updated
to test more commands, since it only seems to be testing `list disk-store` and
`describe disk-store`.
**TESTING STATUS: Precheckin in progress**
- [ ] JIRA ticket referened
- [ ] PR rebased
- [ ] Initial commit is single and squashed
- [ ] `gradlew build` runs cleanly
- [ ] Unit tests updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3258
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/687.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #687
----
commit 55bd2b1613ea02a895b8f38b9760d14c5ffa531e
Author: YehEmily <emilyyeh1...@gmail.com>
Date: 2017-08-03T16:00:08Z
GEODE-3258: Refactoring DiskStoreCommands
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
