Github user jaredjstewart commented on a diff in the pull request:
    --- Diff: 
    @@ -128,9 +128,16 @@ public void testCacheXmlParserWithSimplePool() {
       public void testCacheXmlParserWithSimplePoolXerces() {
    -    System.setProperty("javax.xml.parsers.SAXParserFactory",
    +    String prevParserFactory = 
    --- End diff --
    You can make this cleanup of the system properties more robust by using the 
`RestoreSystemProperties` JUnit rule.  All you need to do is add this as a 
member variable of the test class: 
      public final RestoreSystemProperties restoreSystemProperties = new 
    (For an example see 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to