----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61420/#review182413 -----------------------------------------------------------
Ship it! geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java Lines 2083 (patched) <https://reviews.apache.org/r/61420/#comment258320> since we do the same thing in both cases why not do ``` catch (InterruptedException | DistributedSystemDisconnectedException e) {... ``` - Alexander Murmann On Aug. 3, 2017, 10:07 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61420/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2017, 10:07 p.m.) > > > Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen > O'Sullivan, Udo Kohlmeyer, and Brian Rowe. > > > Repository: geode > > > Description > ------- > > Now we catch DistributedSystemDisconnectedException in ViewCreatoe thread and > then mark shutdown true > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 40a4254 > > > Diff: https://reviews.apache.org/r/61420/diff/1/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
