Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132312583
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -502,7 +507,7 @@ protected static Integer identifyPid() {
}
}
- // TODO refactor the logic in this method into a DateTimeFormatUtils
class
+ // consider refactoring the logic in this method into a
DateTimeFormatUtils class
--- End diff --
I'd remove this and the line 510 comments altogether. If the suggestion
has value, we should open a ticket for it.
Likewise `LocatorLauncher:382`, `ServerLauncher:523`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
