----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61585/ -----------------------------------------------------------
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Repository: geode Description ------- GEODE-3096: pulling in refactoring work on HttpOperationInvoker These are the refactoring work we did on those three weeks, minus the query (which is already in develop), and minus pulling commands into it's own class(Emily's work is gonna help on that one). It's rebased on top of the current develop now. Diffs ----- geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshExecution.java 23f2a73acf2cf92a8b1c0c2ea2afd10392265628 geode-common/src/main/java/org/apache/geode/annotations/TestingOnly.java PRE-CREATION geode-core/build.gradle 9ecb0f9cca43eba4904af6f656bf34551bdd5b15 geode-core/src/main/java/org/apache/geode/management/cli/CommandStatement.java a01f08c2f09b9c762bbd4ef561ce0ba26d22dd73 geode-core/src/main/java/org/apache/geode/management/internal/cli/CommandManager.java 3c8f6cf235d0f1b34d948d23e39fddfbe306be2c geode-core/src/main/java/org/apache/geode/management/internal/cli/CommandRequest.java 00a05872a512f294f914dbc8ac1c12b799a9145d geode-core/src/main/java/org/apache/geode/management/internal/cli/CommandResponse.java 81c49583b759ea815f6f20fb1c6da7edb7f99b2f geode-core/src/main/java/org/apache/geode/management/internal/cli/CommandResponseBuilder.java 3f8f20d1055973f5af6b2a22d8656014cf2c704e geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java 274f61c1f304576f8d8db1d5289875ecea706962 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 84326c09ff24d194469ce8de435d5cf640615d06 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java 83eddeebb472758944863cde098746c7ff8da5a4 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java 20757766ae8aebb2dffbc0b775d8689815ab3fd6 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GfshCommand.java c7f53b1552b45f340b244828cb76d09c8aaa83da geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandExecutor.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java 2464b0065d61b1aafc3b933f5f1a04e90e95c689 geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandStatementImpl.java ac510d1755c7dba1c2c7a772887a5c1b64cdcf57 geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/MemberCommandService.java 25ff549be2bf706c3e3a312fa1b6ce6b423996e7 geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/OnlineCommandProcessor.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 75dce477ba6ce0352ff2575daa7b16f66f1acf18 geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java 0d1d91bc150a364c97d7cd1c23e7ab51bfb41163 geode-core/src/main/java/org/apache/geode/management/internal/cli/result/CommandResult.java 00f1fd9376a144e32824384dab14bbb96ef93973 geode-core/src/main/java/org/apache/geode/management/internal/cli/result/DownloadFileResult.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ErrorResultData.java 7ae0d8083600bba89eb625b95408afc9b9896059 geode-core/src/main/java/org/apache/geode/management/internal/cli/result/InfoResultData.java f399a54159d3e1d8b8a68ec59a8ee68c5ca4bbe7 geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java 94dbca07757fab196522eccc9e1239f6c6911b24 geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java 503c2522b1b9b492e6167940543669b560e490d1 geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java 6794b3ba06c2e5dba944942f9ac099eb51930a80 geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/ScriptExecutionDetails.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/AbstractCommandsController.java 0a18ec522884f5f737045b0da53a0e49e1cd6aa9 geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/ClientCommandsController.java e8df505f35bf751fa5a57acb3cd1d75ea2e0e35c geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/ClusterCommandsController.java fae10debac618594d191f08e9b45b85e71769a32 geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/ConfigCommandsController.java 9f06ea3443da9865df691522f1bde58e04d5f400 geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DataCommandsController.java ce7ebfca56ce8b3448a51c44237b64573366a70e geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DeployCommandsController.java 23c5083d415101c7130c08996371df8f837bd114 geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DiskStoreCommandsController.java 2e068118fcb36a7c569adfc8967983501595c9ed geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DurableClientCommandsController.java 4562cd5280d43b369ed5c1cad9d926d086f6413d geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/ExportLogController.java 87afc24a71394d0b293cd2cc05895b5b9e646b34 geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/FunctionCommandsController.java 855947e74f762425aaf4f95044ace03a366d803d geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/IndexCommandsController.java 296156f973c7e64354ad5815f95e554ef0607f6e geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/LauncherLifecycleCommandsController.java 2e1084211e80da580f5ba25874f2476c62b8cb0d geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/MemberCommandsController.java 66e82ee8ab36c376c482c113e4bfb982171c0a9e geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/MiscellaneousCommandsController.java fd28fedec8df453ddbe74a08fa63590ccfa1e296 geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/PdxCommandsController.java c757fd351ce5e7e0107832d43ee225b089af63e8 geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/QueueCommandsController.java 02d9bcbaae415bae936c241bccc53341f825d03c geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/RegionCommandsController.java 21f85bf854f1b3746383820fcbb73f350348f9b5 geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/ShellCommandsController.java e983f2acb124310b31a5aa713358e1c221065a9a geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/WanCommandsController.java 36b4d2e1a8edd6ae60203100040cecbe9df9fd0c geode-core/src/main/java/org/apache/geode/management/internal/web/http/support/SimpleHttpRequester.java 89adc202616ac5d906abfb361e3c1588acb0ac5d geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java 63eb977278da481b2858e03769175500a147a573 geode-core/src/main/java/org/apache/geode/management/internal/web/shell/HttpOperationInvoker.java a3ce5548ef7a50d6af7bd143d1c2b49301232c15 geode-core/src/main/java/org/apache/geode/management/internal/web/shell/RestHttpOperationInvoker.java 13fd42c41f47b4693e03692052371c14e8512a04 geode-core/src/main/java/org/apache/geode/management/internal/web/shell/SimpleHttpOperationInvoker.java d11d8245b4f164ba4e148d87ea4661eb7f15176c geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfsh.java f636c89ca7be4ca88ff0bae9ff6d0f377a643600 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandsDUnitTest.java eeec317ad0162ad7b5a53232958c15bdb50e8e5a geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandsDUnitTest.java 89148d7752ae1f69e25671ffc43101a63cf7dc64 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandJUnitTest.java da60c7aa481954be0acc8c7e2b88717cf8bc9c37 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java fe6bc404d33b48e5384348241c17ccf924f4627c geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShellCommandsDUnitTest.java 93bba3cdcd6a619b2a29f77d2bb5f238c3665b77 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowDeadlockDUnitTest.java 8b5c80e4dd63d894bb305c618b9c12ca1e318b52 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsDUnitTest.java 5c94c3a390a02c0e9db27e0d452a77e86a110e89 geode-core/src/test/java/org/apache/geode/management/internal/cli/remote/CommandExecutorTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/remote/OnlineCommandProcessorTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/result/CommandResultTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/result/DownloadFileResultTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategyJUnitTest.java ece0c7eea85833369cfe8f9edf4756ca7724c7e2 geode-core/src/test/java/org/apache/geode/management/internal/web/controllers/ExportLogControllerTest.java bee7db219ebd07460d7e9ee94568e9294e911eac geode-core/src/test/java/org/apache/geode/management/internal/web/controllers/ShellCommandsControllerProcessCommandTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/web/controllers/WanCommandsControllerJUnitTest.java 59d6ff43b2ed2cc7639ba1d97345eda9b3ece583 geode-core/src/test/java/org/apache/geode/management/internal/web/shell/HttpOperationInvokerMBeanOperationTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/web/shell/HttpOperationInvokerTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java e7f17ef208a1708f385c7c4041affb70fd309a4c geode-junit/build.gradle 7c533adbebff1c32a546786865d71c376e185189 geode-junit/src/main/java/org/apache/geode/test/junit/ResultCaptor.java PRE-CREATION geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpTest.java PRE-CREATION geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandWithHttpAndSSLDUnitTest.java 8ab45b7bd775a76a1fa7051121b37a70b819c649 geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/QueryNamesOverHttpDUnitTest.java dbd29b53f42d61d00f895340d3568455c6ccb890 geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/ShellCommandsControllerJUnitTest.java 2f9214ce46e4095fb2d061e6a05411e8cf0b8db9 geode-web/src/test/java/org/apache/geode/management/internal/web/shell/HttpOperationInvokerTest.java PRE-CREATION geode-web/src/test/java/org/apache/geode/management/internal/web/shell/RestHttpOperationInvokerJUnitTest.java 2bebd2ef2e5edc70b3e90458968ebc6e42a4b597 geode-web/src/test/java/org/apache/geode/management/internal/web/shell/SimpleHttpOperationInvokerJUnitTest.java 4571f2ca2f459d40b5a0d42055cf8b2e9b747220 Diff: https://reviews.apache.org/r/61585/diff/1/ Testing ------- precheckin running Thanks, Jinmei Liao
