Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/699#discussion_r132599768
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/internal/process/FileProcessController.java
 ---
    @@ -112,56 +119,43 @@ private void stop(final File workingDir, final String 
stopRequestFileName) throw
       private String status(final File workingDir, final String 
statusRequestFileName,
           final String statusFileName) throws IOException, 
InterruptedException, TimeoutException {
         // monitor for statusFile
    -    final File statusFile = new File(workingDir, statusFileName);
    -    final AtomicReference<String> statusRef = new AtomicReference<>();
    -
    -    final ControlRequestHandler statusHandler = new 
ControlRequestHandler() {
    -      @Override
    -      public void handleRequest() throws IOException {
    -        // read the statusFile
    -        final BufferedReader reader = new BufferedReader(new 
FileReader(statusFile));
    -        final StringBuilder lines = new StringBuilder();
    -        try {
    -          String line = null;
    -          while ((line = reader.readLine()) != null) {
    -            lines.append(line);
    -          }
    -        } finally {
    -          statusRef.set(lines.toString());
    -          reader.close();
    +    File statusFile = new File(workingDir, statusFileName);
    +    AtomicReference<String> statusRef = new AtomicReference<>();
    +
    +    ControlRequestHandler statusHandler = () -> {
    --- End diff --
    
    Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to