I merged in 16 PRs today and precheckin was clean for each individually. I launched a precheckin after all were merged in and that seems to have tons of Management test failures. So on Monday, I'll try to identify which PRs aren't playing nicely with each other and start backing them out. Sorry the tests are going to be so messy for the weekend.
I think this is one of the times where trying to separate a huge refactoring out into many tickets just didn't work. Sorry code reviewers, but some of these refactorings are going to have to be HUGE change-sets. :geode-core:integrationTest org.apache.geode.management.internal.cli.help.HelperIntegrationTest > testHelpWithNoInput FAILED java.lang.AssertionError: Expected size:<2> but was:<4> in: <["help (Available)", "Display syntax and usage information for all commands or list all available commands if <command> isn't specified.", "hint (Available)", "Provide hints for a topic or list all available topics if "topic" isn't specified."]> at org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69) org.apache.geode.management.internal.cli.help.HelperIntegrationTest > testHintWithNoInput FAILED java.lang.AssertionError: Expected size:<21> but was:<22> in: <["Hints are available for the following topics. Use "hint <topic-name>" for a specific hint.", "", "Client", "Cluster Configuration", "Configuration", "Data", "Debug-Utility", "Disk Store", "Function Execution", "GFSH", "Geode", "Help", "JMX", "Lifecycle", "Locator", "Logs", "Management-Monitoring", "Manager", "Region", "Server", "Statistics", "WAN"]> at org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96) org.apache.geode.management.internal.cli.GfshParserConverterTest > testHintConverter FAILED java.lang.StringIndexOutOfBoundsException: String index out of range: -1 at java.lang.String.substring(String.java:1931) at org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265) at java.util.ArrayList.replaceAll(ArrayList.java:1442) at org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264) at org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58) at org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126) org.apache.geode.management.internal.security.CliCommandsSecurityTest > testNoAccess FAILED org.assertj.core.api.SoftAssertionError: The following assertion failed: 1) [destroy function --id=InterestCalculations] Expecting: <"stranger not authorized for CLUSTER:MANAGE:JAR"> to contain: <"DATA:MANAGE"> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74) at org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134) at org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78) org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testRegionAReader FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testRegionAReader(GfshCommandsSecurityTest.java:108) org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testRegionAWriter FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testRegionAWriter(GfshCommandsSecurityTest.java:114) org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testClusterReader FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testClusterReader(GfshCommandsSecurityTest.java:72) org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testClusterWriter FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testClusterWriter(GfshCommandsSecurityTest.java:78) org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testClusterManager FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testClusterManager(GfshCommandsSecurityTest.java:84) org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testDataReader FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testDataReader(GfshCommandsSecurityTest.java:90) org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testRegionAManager FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testRegionAManager(GfshCommandsSecurityTest.java:120) org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testDataWriter FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164) at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testDataWriter(GfshCommandsSecurityTest.java:96) org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest > testSerializables FAILED java.lang.AssertionError: New or moved classes---------------------------------------- org/apache/geode/internal/cache/snapshot/ParallelSnapshotFileMapper,true,1 If the class is not persisted or sent over the wire add it to the file /tmp/build/ae3c03f4/gemfire/open/geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt Otherwise if this doesn't break backward compatibility, copy the file /tmp/build/ae3c03f4/geode/geode-core/build/integrationTest/actualSerializables.dat to /tmp/build/ae3c03f4/gemfire/open/geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt. at org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest.testSerializables(AnalyzeSerializablesJUnitTest.java:150) 3715 tests completed, 13 failed, 140 skipped :geode-core:integrationTest FAILED :geode-web:integrationTest org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testRegionAReader FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testRegionAWriter FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testClusterReader FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testClusterWriter FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testClusterManager FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testDataReader FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testRegionAManager FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testDataWriter FAILED org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]> 30 tests completed, 8 failed :geode-web:integrationTest FAILED