Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/707#discussion_r132878378
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
 ---
    @@ -63,6 +65,31 @@ private static ClientProtocolMessageHandler 
findClientProtocolMessageHandler() {
         }
       }
     
    +  private static Class<? extends StreamAuthenticator> 
findStreamAuthenticator(
    +      String implementationID) {
    +    if (authenticatorClass != null) {
    +      return authenticatorClass;
    +    }
    +
    +    synchronized (streamAuthenticatorLoadLock) {
    --- End diff --
    
    Once `authenticatorClass` is initialized, there will no longer be any 
synchronization necessary in this method. This means that each thread will need 
to synchronize at most once, which means no locking / cache misses.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to