> On Aug. 16, 2017, 10:47 p.m., anilkumar gingade wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java > > Line 1024 (original), 1024 (patched) > > <https://reviews.apache.org/r/61676/diff/1/?file=1798418#file1798418line1024> > > > > And remove this one too...
Yes, in both cases the wrapped exception thrown is getting caught by that outer catch block. - Nick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61676/#review183078 ----------------------------------------------------------- On Aug. 15, 2017, 10:47 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61676/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2017, 10:47 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, > and Nick Reich. > > > Bugs: GEODE-3444 > https://issues.apache.org/jira/browse/GEODE-3444 > > > Repository: geode > > > Description > ------- > > When JTA transaction failed with exception, it is better to release the locks > it held right away. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java > 55415e3 > > > Diff: https://reviews.apache.org/r/61676/diff/1/ > > > Testing > ------- > > Precheckin. > > > Thanks, > > Eric Shu > >
