GitHub user jhuynh1 opened a pull request:
https://github.com/apache/geode/pull/718
GEODE-3434: Allow old tomcat server sessions to be compatible with new
tomcat session modules
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/geode feature/GEODE-3434
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/718.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #718
----
commit 08c29c8df14b8cc315551297477636237e855b48
Author: Jason Huynh <[email protected]>
Date: 2017-08-14T16:02:11Z
GEODE-3434: Allow the modules to be interoperable with current and older
versions of tomcat 7
Modified DeltaSessions to use reflection to handle attributes fields incase
an earlier tomcat 7 is used
Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession
Added session backward compatibility tests
Modified aseembly build to download old product installs
commit dfce284c2634ea72e797ad4a9d8c956b8d86211c
Author: Jason Huynh <[email protected]>
Date: 2017-08-14T19:07:08Z
GEODE-3434: Modifications based on review comments
commit be305896685e1b7d4d1f37724f673701277e5a76
Author: Jason Huynh <[email protected]>
Date: 2017-08-15T18:46:16Z
Removed unused import
commit d282ec4470a3993f7b401675bf7eb4161e1fb66e
Author: Jason Huynh <[email protected]>
Date: 2017-08-17T22:04:42Z
updated
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
