Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134005011
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
---
@@ -392,7 +388,7 @@ public void testLocatorUpdateIntervalZero() throws
Exception {
private void startFakeLocator() throws UnknownHostException,
IOException, InterruptedException {
server = new TcpServer(port, InetAddress.getLocalHost(), null, null,
handler, new FakeHelper(),
- Thread.currentThread().getThreadGroup(), "Tcp Server");
+ Thread.currentThread().getThreadGroup(), "Tcp Server", null);
--- End diff --
We added another parameter "protobuf handler" for TcpServer constructor to
process protobuf messages. And it is nothing to do with existing code base and
is only relevant for Protobuf requests. That's why we are passing null for old
code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
