-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61816/
-----------------------------------------------------------
(Updated Aug. 23, 2017, 8:47 a.m.)
Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra,
Udo Kohlmeyer, and Brian Rowe.
Changes
-------
fixed a race condition in the new test. The setup method connects a socket to
the server so the initial connection count ought to be 1 but often was zero.
When it was 1 the incorrect assertions in the new test would fail.
Bugs: GEODE-3409
https://issues.apache.org/jira/browse/GEODE-3409
Repository: geode
Description
-------
ServerConnection cleanup was not decrementing the Acceptor's client connection
count when the protobuf communications mode was in effect.
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
35cc33f3fa5547a01368a3ae3b6ad401b858610d
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
394d2614c0d04353c95454c8730e84688e4766fe
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
12cc08b2f6cac77dcc2b79f1d3245f0960c3e8ba
Diff: https://reviews.apache.org/r/61816/diff/2/
Changes: https://reviews.apache.org/r/61816/diff/1-2/
Testing
-------
new integration test
Thanks,
Bruce Schuchardt
